Ice sheet thickness boundary condition #474
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #474 +/- ##
============================================
- Coverage 37.54% 37.54% -0.01%
============================================
Files 270 270
Lines 79030 79030
Branches 14633 14635 +2
============================================
- Hits 29671 29670 -1
- Misses 43892 43894 +2
+ Partials 5467 5466 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marshallward
force-pushed
the
dev/gfdl
branch
from
8a66adc
to
9de6ce7
Compare
…e for ice sheet velocity
…e for ice sheet velocity, part 2
There was a problem hiding this comment.
These changes look good to me, although at some point we might want to reconsider whether ISS%hmask is an array of reals or integers, since it is being used almost every where as though it is an integer. Also, there are some instances of using .ne. in comparisons, whereas the preferred syntax is the more succinct \=. None of these issues is material enough to impact the value of this commit, however, and they might be addressed later.
Allow assignment of ice shelf thickness (Dirichlet condition) wherever hmask == 3. This seems to have been only partially implemented previously. This commit has been tested by ensuring that modeled ice-shelf evolution can match the analytical "flow-band" ice-flow solution with thickness enforced at the western boundary.